Skip to content

metis: add install-plugin.sh#1021

Merged
k8s-ci-robot merged 6 commits intokubernetes:masterfrom
arvindbr8:build-cd
Apr 7, 2026
Merged

metis: add install-plugin.sh#1021
k8s-ci-robot merged 6 commits intokubernetes:masterfrom
arvindbr8:build-cd

Conversation

@arvindbr8
Copy link
Copy Markdown
Contributor

@arvindbr8 arvindbr8 commented Mar 26, 2026

This diff adds install-plugin.sh, the script which will be run within ctr for metis installables

cc: @YifeiZhuang @gnossen @zhaoqsh

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 26, 2026

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 26, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 26, 2026

Hi @arvindbr8. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 26, 2026
@arvindbr8
Copy link
Copy Markdown
Contributor Author

arvindbr8 commented Mar 26, 2026

/hold need to wait for other dependencies to rollout

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2026
@YifeiZhuang
Copy link
Copy Markdown
Contributor

YifeiZhuang commented Mar 27, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 27, 2026
@YifeiZhuang
Copy link
Copy Markdown
Contributor

YifeiZhuang commented Mar 27, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 27, 2026
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2026
@arvindbr8
Copy link
Copy Markdown
Contributor Author

arvindbr8 commented Mar 27, 2026

@YifeiZhuang Please take a look at the updated Makefile per our discussion to changes in the CD pipeline change

@YifeiZhuang
Copy link
Copy Markdown
Contributor

YifeiZhuang commented Mar 31, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 31, 2026
arvindbr8 added 3 commits April 7, 2026 10:54
@arvindbr8
Merge origin/master into build-cd
35f4a85
@arvindbr8
Merge branch 'master' into build-cd
4e277d7
@arvindbr8
feat(metis): modernize build pipeline and resolve conflicts
f975fd5 
- Resolved merge conflicts in Makefile after pulling master.
- Sanitized GIT_VERSION to avoid k8s component-base panic.
- Consolidated TAG and GIT_VERSION variables for readability.
- Updated build-image-local to use buildx with --load.
- Moved binary to /bin/metis in Dockerfile and updated Makefile extraction path.
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 7, 2026
@YifeiZhuang
Copy link
Copy Markdown
Contributor

YifeiZhuang commented Apr 7, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arvindbr8, gnossen, YifeiZhuang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@arvindbr8
Copy link
Copy Markdown
Contributor Author

arvindbr8 commented Apr 7, 2026 •
edited
Loading

/unhold Thanks for the review

@arvindbr8
Copy link
Copy Markdown
Contributor Author

arvindbr8 commented Apr 7, 2026

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2026
@k8s-ci-robot k8s-ci-robot merged commit 0f155a4 into kubernetes:master Apr 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bridgetkromhout bridgetkromhout Awaiting requested review from bridgetkromhout

@elmiko elmiko Awaiting requested review from elmiko

1 more reviewer

@gnossen gnossen gnossen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@YifeiZhuang YifeiZhuang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arvindbr8 @k8s-ci-robot @YifeiZhuang @gnossen